[PATCH] D120049: [DAG-ISEL]remove unnecessary getNode() for SDValue type. NFC
ChenZheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 17 06:16:12 PST 2022
shchenz created this revision.
shchenz added reviewers: craig.topper, spatel, RKSimon, jsji.
Herald added subscribers: ecnelises, steven.zhang, hiraditya.
shchenz requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
SDValue overloads operator `->`, so SDValue.getNode()->func() can be written as SDValue->func()?
Grep `.getNode()->` in llvm code base, there are many such usages.
I remove the unnecessary usage in the file DAGCombiner.cpp to get some feedback first.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D120049
Files:
llvm/include/llvm/CodeGen/SelectionDAGNodes.h
llvm/include/llvm/CodeGen/TargetLowering.h
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120049.409618.patch
Type: text/x-patch
Size: 24672 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220217/48f7460a/attachment.bin>
More information about the llvm-commits
mailing list