[PATCH] D119006: [AMDGPU] SILoadStoreOptimizer: avoid unbounded register pressure increases

[Jay Foad via Phabricator via llvm-commits]

foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:604-605
+    return false;
+  // TODO: Use LaneMasks for virtregs to allow non-conflicting subreg uses/defs.
+  // FIXME: Use RegUnits for physreg operands to detect partial overlaps.
+  for (const auto &BOp : B.operands()) {
----------------
arsenm wrote:
> foad wrote:
> > arsenm wrote:
> > > Generally those don't exist at this point outside of copies
> > What don't? Subregs or partial physreg overlaps or both?
> Both. In SSA those generally appear as plain copies to do the extract or copy from physreg
OK, I just removed the comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119006/new/

https://reviews.llvm.org/D119006