[PATCH] D119578: [X86] selectLEAAddr - add X86ISD::SMUL/UMULO handling

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 01:57:38 PST 2022


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/xmulo.ll:489-492
 ; WIN32-NEXT:    movl %ecx, %edx
-; WIN32-NEXT:    movl %eax, %esi
 ; WIN32-NEXT:    seto %ch
 ; WIN32-NEXT:    orb %bh, %ch
+; WIN32-NEXT:    leal (%edi,%eax), %esi
----------------
pengfei wrote:
> No sure if it's always beneficial. IIRC, we have some disadvantages on decoding complex lea.
Does Intel arch count simple add lea with a different dst reg as complex?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119578/new/

https://reviews.llvm.org/D119578



More information about the llvm-commits mailing list