[llvm] 1822a5e - [AMDGPU] Return better Changed status from AMDGPUPerfHintAnalysis

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 01:32:13 PST 2022


Author: Jay Foad
Date: 2022-02-17T09:31:42Z
New Revision: 1822a5ecdd363ffcf465a7ad2e4e6fb92cab69f7

URL: https://github.com/llvm/llvm-project/commit/1822a5ecdd363ffcf465a7ad2e4e6fb92cab69f7
DIFF: https://github.com/llvm/llvm-project/commit/1822a5ecdd363ffcf465a7ad2e4e6fb92cab69f7.diff

LOG: [AMDGPU] Return better Changed status from AMDGPUPerfHintAnalysis

Differential Revision: https://reviews.llvm.org/D119944

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp b/llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp
index 8ad344816ad2..de97b76b1e09 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp
@@ -267,19 +267,23 @@ bool AMDGPUPerfHint::runOnFunction(Function &F) {
                     << " LSMInst cost: " << Info->LSMInstCost << '\n'
                     << " TotalInst cost: " << Info->InstCost << '\n');
 
+  bool Changed = false;
+
   if (isMemBound(*Info)) {
     LLVM_DEBUG(dbgs() << F.getName() << " is memory bound\n");
     NumMemBound++;
     F.addFnAttr("amdgpu-memory-bound", "true");
+    Changed = true;
   }
 
   if (AMDGPU::isEntryFunctionCC(F.getCallingConv()) && needLimitWave(*Info)) {
     LLVM_DEBUG(dbgs() << F.getName() << " needs limit wave\n");
     NumLimitWave++;
     F.addFnAttr("amdgpu-wave-limiter", "true");
+    Changed = true;
   }
 
-  return true;
+  return Changed;
 }
 
 bool AMDGPUPerfHint::isMemBound(const AMDGPUPerfHintAnalysis::FuncInfo &FI) {


        


More information about the llvm-commits mailing list