[llvm] 77e793d - [AMDGPU] Return better Changed status from AMDGPUAnnotateUniformValues
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 17 01:32:11 PST 2022
Author: Jay Foad
Date: 2022-02-17T09:31:42Z
New Revision: 77e793d0255b67454176257d8306c932704ebd94
URL: https://github.com/llvm/llvm-project/commit/77e793d0255b67454176257d8306c932704ebd94
DIFF: https://github.com/llvm/llvm-project/commit/77e793d0255b67454176257d8306c932704ebd94.diff
LOG: [AMDGPU] Return better Changed status from AMDGPUAnnotateUniformValues
Differential Revision: https://reviews.llvm.org/D119943
Added:
Modified:
llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp b/llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp
index 440c527addff9..74be0336851cc 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp
@@ -33,6 +33,17 @@ class AMDGPUAnnotateUniformValues : public FunctionPass,
MemorySSA *MSSA;
AliasAnalysis *AA;
bool isEntryFunc;
+ bool Changed;
+
+ void setUniformMetadata(Instruction *I) {
+ I->setMetadata("amdgpu.uniform", MDNode::get(I->getContext(), {}));
+ Changed = true;
+ }
+
+ void setNoClobberMetadata(Instruction *I) {
+ I->setMetadata("amdgpu.noclobber", MDNode::get(I->getContext(), {}));
+ Changed = true;
+ }
public:
static char ID;
@@ -66,13 +77,6 @@ INITIALIZE_PASS_END(AMDGPUAnnotateUniformValues, DEBUG_TYPE,
char AMDGPUAnnotateUniformValues::ID = 0;
-static void setUniformMetadata(Instruction *I) {
- I->setMetadata("amdgpu.uniform", MDNode::get(I->getContext(), {}));
-}
-static void setNoClobberMetadata(Instruction *I) {
- I->setMetadata("amdgpu.noclobber", MDNode::get(I->getContext(), {}));
-}
-
void AMDGPUAnnotateUniformValues::visitBranchInst(BranchInst &I) {
if (DA->isUniform(&I))
setUniformMetadata(&I);
@@ -109,8 +113,9 @@ bool AMDGPUAnnotateUniformValues::runOnFunction(Function &F) {
AA = &getAnalysis<AAResultsWrapperPass>().getAAResults();
isEntryFunc = AMDGPU::isEntryFunctionCC(F.getCallingConv());
+ Changed = false;
visit(F);
- return true;
+ return Changed;
}
FunctionPass *
More information about the llvm-commits
mailing list