[PATCH] D119954: [CodeGen] Return better Changed status from PostRAHazardRecognizer

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 00:51:32 PST 2022


piotr added inline comments.


================
Comment at: llvm/lib/CodeGen/PostRAHazardRecognizer.cpp:98
   }
-  return true;
+  return Changed;
 }
----------------
myhsu wrote:
> piotr wrote:
> > You can check NumNoops here instead?
> I don't think so, `NumNoops` is a global variable that accumulates its value through the program's lifetime
> I don't think so, `NumNoops` is a global variable that accumulates its value through the program's lifetime

Ah, of course.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119954/new/

https://reviews.llvm.org/D119954



More information about the llvm-commits mailing list