[PATCH] D119954: [CodeGen] Return better Changed status from PostRAHazardRecognizer
Min-Yih Hsu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 16 13:01:40 PST 2022
myhsu added inline comments.
================
Comment at: llvm/lib/CodeGen/PostRAHazardRecognizer.cpp:89
NumNoops += NumPreNoops;
+ if (NumPreNoops != 0)
+ Changed = true;
----------------
nit
================
Comment at: llvm/lib/CodeGen/PostRAHazardRecognizer.cpp:98
}
- return true;
+ return Changed;
}
----------------
piotr wrote:
> You can check NumNoops here instead?
I don't think so, `NumNoops` is a global variable that accumulates its value through the program's lifetime
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119954/new/
https://reviews.llvm.org/D119954
More information about the llvm-commits
mailing list