[PATCH] D119898: [MemorySSA] Clear VisitedBlocks per query

[Whitney Tsang via Phabricator via llvm-commits]

Whitney created this revision.
Whitney added reviewers: asbirlea, fhahn.
Whitney added a project: LoopOptWG.
Herald added subscribers: george.burgess.iv, hiraditya.
Whitney requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

I am not sure my fix is the best approach, but it fixes the assertion. Could it be an issue with how I use the `MemorySSAUpdater` in the test case?

The problem can be shown from the newly added test case. 
There are two invocations to `MemorySSAUpdater::moveToPlace`, and the internal data structure `VisitedBlocks` is changed in the first invocation, and reused in the second invocation. In between the two invocations, there is a change to the CFG, and `MemorySSAUpdater` is notified about the change.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119898

Files:
  llvm/lib/Analysis/MemorySSAUpdater.cpp
  llvm/unittests/Analysis/MemorySSATest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119898.409069.patch
Type: text/x-patch
Size: 4290 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220215/f3a46d9e/attachment.bin>