[PATCH] D119665: [M68k] Adopt VarLenCodeEmitter for control instructions

Tue Feb 15 05:01:16 PST 2022

ricky26 added inline comments.

================
Comment at: llvm/test/MC/M68k/Control/call-pc-rel.s:3
 ; RUN: llvm-mc -triple=m68k -filetype=obj < %s | \
-; RUN:     llvm-objdump -d - | FileCheck --check-prefix=CHECK-OBJ %s
+; RUN:     llvm-objdump -d - | not FileCheck --check-prefix=CHECK-OBJ %s

----------------
0x59616e wrote:
> ricky26 wrote:
> > It looks like this just negates the whole test?
> This just negates the second test, which needs disassembler support.
> 
> The first test is still online.
Is it worth adding a `TODO:` here? I don't want it to get lost and I don't think it would be immediately obvious to me that it was disabled.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119665/new/

https://reviews.llvm.org/D119665