[PATCH] D119665: [M68k] Adopt VarLenCodeEmitter for control instructions

Tue Feb 15 04:35:30 PST 2022

0x59616e added inline comments.

================
Comment at: llvm/lib/Target/M68k/M68kInstrControl.td:47
+  def NOP : MxInst<(outs), (ins), "nop", []> {
+    let Inst = (descend 0b0100, 0b1110, 0b0111, 0b0001);
+  }
----------------
ricky26 wrote:
> nit: Any reason you've split this up by byte? Generally the manuals I've read have it as one string of bits (I wonder if the bit syntax supports underscores).
Just for readability.

And...no, the bit syntax does not support underscore.

================
Comment at: llvm/test/MC/M68k/Control/call-pc-rel.s:3
 ; RUN: llvm-mc -triple=m68k -filetype=obj < %s | \
-; RUN:     llvm-objdump -d - | FileCheck --check-prefix=CHECK-OBJ %s
+; RUN:     llvm-objdump -d - | not FileCheck --check-prefix=CHECK-OBJ %s

----------------
ricky26 wrote:
> It looks like this just negates the whole test?
This just negates the second test, which needs disassembler support.

The first test is still online.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119665/new/

https://reviews.llvm.org/D119665