[PATCH] D89216: [dsymutil] Add the ability to run the DWARF verifier on the input

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 13:45:39 PST 2022


clayborg accepted this revision.
clayborg added a comment.

In D89216#3320823 <https://reviews.llvm.org/D89216#3320823>, @clayborg wrote:

> Most of the patch looks fine, just wanted to make sure we aren't changing it so that "--verify" can't be specified without a now required argument as it would break people's scripts for anyone that is using this flag. We are using on all iOS DWARF output right now at Facebook/Meta. I would rather us add a new "--verify-input" that can be specified, and add leave "--verify" to mean verify the output, or make a "--verify-output" as well and alias "--verify" to that flag.

This will teach me to read all of the posts and the original description before commenting... If everything is as it says in the description this looks good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89216/new/

https://reviews.llvm.org/D89216



More information about the llvm-commits mailing list