[PATCH] D89216: [dsymutil] Add the ability to run the DWARF verifier on the input

[Greg Clayton via Phabricator via llvm-commits]

clayborg added a comment.

All of the path looks like, just wanted to make sure we aren't changing it so that "--verify" can't be specified without a now required argument as it would break people's scripts for anyone that is using this flag. We are using on all iOS DWARF output right now at Facebook/Meta. I would rather us add a new "--verify-input" that can be specified, and add leave "--verify" to mean verify the output, or make a "--verify-output" as well and alias "--verify" to that flag.



================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:260
+
+  if (Expected<DWARFVerify> Verify = getVerifyKind(Args)) {
+    Options.Verify = *Verify;
----------------
Is this now changing it so "--verify" no longer works and now requires an additional argument? It would hate to break anyone's scripts that might be currently using the "--verify" option by changing its semantics.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89216/new/

https://reviews.llvm.org/D89216