[PATCH] D119171: [SelectionDAG][RISCV][ARM][PowerPC][X86][WebAssembly] Change default abs expansion to use sra (X, size(X)-1); sub (xor (X, Y), Y).
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 11 05:22:11 PST 2022
RKSimon added a comment.
I've no objections to using this instead of D119099 <https://reviews.llvm.org/D119099>, even with the x86 i8 codegen change
================
Comment at: llvm/test/CodeGen/RISCV/rv64zbb.ll:959
; FIXME: We can remove the sext.w by using addw for RV64I and negw for RV64ZBB.
define signext i32 @abs_i32_sext(i32 signext %x) {
----------------
update FIXME?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119171/new/
https://reviews.llvm.org/D119171
More information about the llvm-commits
mailing list