[PATCH] D119013: [ArgPromotion][AMDGPU] New MSSA-based function argument promotion pass with input/output argument support

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D119013#3303944 <https://reviews.llvm.org/D119013#3303944>, @nikic wrote:

> In D119013#3300906 <https://reviews.llvm.org/D119013#3300906>, @vpykhtin wrote:
>
>>> Please ensure your implementation does not depend on calls to getPointerElementType() -- you can determine the type based on load/store instructions.
>>
>> @nikic  Thanks, why is this better? (half done BTW)
>
> This method is deprecated and will be removed in the future, see https://llvm.org/docs/OpaquePointers.html for context.

See https://reviews.llvm.org/D118685 changes to the original argpromo pass to make it work with opaque pointers (which makes it nicer in general).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119013/new/

https://reviews.llvm.org/D119013