[PATCH] D119013: [ArgPromotion][AMDGPU] New MSSA-based function argument promotion pass with input/output argument support

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 02:32:40 PST 2022


nikic added a comment.

In D119013#3300906 <https://reviews.llvm.org/D119013#3300906>, @vpykhtin wrote:

>> Please ensure your implementation does not depend on calls to getPointerElementType() -- you can determine the type based on load/store instructions.
>
> @nikic  Thanks, why is this better? (half done BTW)

This method is deprecated and will be removed in the future, see https://llvm.org/docs/OpaquePointers.html for context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119013/new/

https://reviews.llvm.org/D119013



More information about the llvm-commits mailing list