[PATCH] D119623: [SLP] Simplify indices processing for insertelements

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:9603
+        getInsertIndex(LastInsertInst, OperandOffset);
     if (!OperandIndex)
       return false;
----------------
anton-afanasyev wrote:
> ABataev wrote:
> > anton-afanasyev wrote:
> > > @ABataev Do you mean this check?
> > Yes, but I thought about returning `true` here.
> Hmm, but `true` means that this insertelement is a part of buildvector. Do you want this?
True means that we have a buildvector, but do not include this insertelement into the list of the vectorisable insertelements, i.e. treat it as an initial vector of the buildvector. Could you try this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119623/new/

https://reviews.llvm.org/D119623