[PATCH] D119623: [SLP] Simplify indices processing for insertelements

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 13 14:02:55 PST 2022


anton-afanasyev marked an inline comment as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:9603
+        getInsertIndex(LastInsertInst, OperandOffset);
     if (!OperandIndex)
       return false;
----------------
ABataev wrote:
> anton-afanasyev wrote:
> > @ABataev Do you mean this check?
> Yes, but I thought about returning `true` here.
Hmm, but `true` means that this insertelement is a part of buildvector. Do you want this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119623/new/

https://reviews.llvm.org/D119623



More information about the llvm-commits mailing list