[PATCH] D119079: [llvm] [cmake] Fix finding modern ounit2

Shiwei Weng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 13 13:43:01 PST 2022


arbipher added a comment.

I saw that. My concern is the tests themselves don't use `ounit`.

In my checking, the tests `llvm/test/Bindings/OCaml/<test>.ml` uses the ocaml binaries `ocamlc ...`  `ocamlopt  ...` but no `ounit`.
There is also no ounit tests in the binding's source code (`llvm/bindindings/ocaml`) (checked <https://discuss.ocaml.org/t/question-on-ounit-with-test-in-llvms-opam-file/9319/3> with the ocaml community but we can wait for some time)

btw, I think it's fine to keep it as it is. I will need more time to investigate it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119079/new/

https://reviews.llvm.org/D119079



More information about the llvm-commits mailing list