[PATCH] D118118: [SDAG] Preserve unpredictable metadata, teach X86CmovConversion to respect this metadata

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:1815
 
-  static uint16_t copyFlagsFromInstruction(const Instruction &I);
+  static uint32_t copyFlagsFromInstruction(const Instruction &I);
 
----------------
Have you been able to ensure none of the callers of these functions implicitly truncate back to u16?


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:389
   bool NoFPExcept : 1;
+  bool Unpredictable : 1;
 
----------------
Missing comment description?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118118/new/

https://reviews.llvm.org/D118118