[PATCH] D118118: [SDAG] Preserve unpredictable metadata, teach X86CmovConversion to respect this metadata

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 05:32:13 PST 2022


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:122
   MachineOperand *Operands = nullptr;   // Pointer to the first operand.
   unsigned NumOperands = 0;             // Number of operands on instruction.
 
----------------
xbolva00 wrote:
> xbolva00 wrote:
> > Do we need *uint32* for NumOperands?
> @RKSimon @craig.topper ?
That might be possible - maybe investigate with a suitable check inside MachineInstr::addOperand?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118118/new/

https://reviews.llvm.org/D118118



More information about the llvm-commits mailing list