[PATCH] D111437: [SystemZ/z/OS] Implement GOFF writer for empty files
Kai Nacke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 11 11:55:31 PST 2022
Kai added a comment.
> I wouldn't use `flags_t'. Isn't that namespace reserved by the standard?
My rational is that I mimic a standard type like `uint64_t`. Well, may be better to change, to avoid fruitless discussions.
> It would be helpful if you used the 'git clang-format' command to reformat _only_ the parts that you are changing. There seem to be a number of places that aren't GOFF but have changed formatting. See 'clang/tools/clang-format'.
Thanks! I do not note that, even if it so obvious. I change it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111437/new/
https://reviews.llvm.org/D111437
More information about the llvm-commits
mailing list