[PATCH] D111437: [SystemZ/z/OS] Implement GOFF writer for empty files

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added a comment.

In D111437#3100240 <https://reviews.llvm.org/D111437#3100240>, @Kai wrote:

> More comments about the implementation?
> E.g. is the name `flags_t` acceptable?

I wouldn't use `flags_t'. Isn't that namespace reserved by the standard?

It would be helpful if you used the 'git clang-format' command to reformat _only_ the parts that you are changing. There seem to be a number of places that aren't GOFF but have changed formatting. See 'clang/tools/clang-format'.

I have no experience in the MC layer so there's not much I can say about those connecting bits.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111437/new/

https://reviews.llvm.org/D111437