[PATCH] D119543: [demangler][NFC] Tweak legacy uuidof handling

Nathan Sidwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 11 06:27:13 PST 2022


urnathan created this revision.
urnathan added reviewers: bruno, iains, ChuanqiXu.
urnathan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We have to special-case 'u 8__uuidof [tz]' demangling for legacy support.  That handling is a little duplicative.

- It seems better to just push the single expected node.

- We can also use 'consumeIf' rather than open-coding the peeking and increment.

- We don't need the numLeft < 2 check, as if there are few than that   other paths will end up with detecting the error.

FWIW This simplifies a future change adding operator precedence.


https://reviews.llvm.org/D119543

Files:
  libcxxabi/src/demangle/ItaniumDemangle.h
  llvm/include/llvm/Demangle/ItaniumDemangle.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119543.407863.patch
Type: text/x-patch
Size: 3514 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220211/520ba1f8/attachment.bin>


More information about the llvm-commits mailing list