[llvm] 2c5dfee - Addressed review comments

[Florian Hahn via llvm-commits]

Hi

> On Feb 10, 2022, at 20:25, YASHASVI KHATAVKAR via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> 
> Author: YASHASVI KHATAVKAR
> Date: 2022-02-10T15:24:50-05:00
> New Revision: 2c5dfeed2f7713c17ce457b4f82dce052fee1363
> 
> URL: https://github.com/llvm/llvm-project/commit/2c5dfeed2f7713c17ce457b4f82dce052fee1363
> DIFF: https://github.com/llvm/llvm-project/commit/2c5dfeed2f7713c17ce457b4f82dce052fee1363.diff
> 
> LOG: Addressed review comments


It looks like you committed a set of changes that seem to belong to the same review, but there is not reference to the actual review on reviews.llvm.org <http://reviews.llvm.org/> and no details in the commit messages. If the commits all relate to the same review, should they have been squashed into a single commit, with a more detailed commit message?

Cheers,
Florian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220211/0401c4b8/attachment.html>