<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 10, 2022, at 20:25, YASHASVI KHATAVKAR via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class="">Author: YASHASVI KHATAVKAR<br class="">Date: 2022-02-10T15:24:50-05:00<br class="">New Revision: 2c5dfeed2f7713c17ce457b4f82dce052fee1363<br class=""><br class="">URL: <a href="https://github.com/llvm/llvm-project/commit/2c5dfeed2f7713c17ce457b4f82dce052fee1363" class="">https://github.com/llvm/llvm-project/commit/2c5dfeed2f7713c17ce457b4f82dce052fee1363</a><br class="">DIFF: <a href="https://github.com/llvm/llvm-project/commit/2c5dfeed2f7713c17ce457b4f82dce052fee1363.diff" class="">https://github.com/llvm/llvm-project/commit/2c5dfeed2f7713c17ce457b4f82dce052fee1363.diff</a><br class=""><br class="">LOG: Addressed review comments<br class=""></div></div></blockquote></div><br class=""><div class=""><br class=""></div><div class="">It looks like you committed a set of changes that seem to belong to the same review, but there is not reference to the actual review on <a href="http://reviews.llvm.org" class="">reviews.llvm.org</a> and no details in the commit messages. If the commits all relate to the same review, should they have been squashed into a single commit, with a more detailed commit message?</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Florian</div></body></html>