[PATCH] D118998: [DebugInfo][InstrRef] Don't fire assertions if broken debug-info is seen

Thu Feb 10 03:13:28 PST 2022

jmorse added a comment.

In D118998#3304180 <https://reviews.llvm.org/D118998#3304180>, @Orlando wrote:

> LGTM. Converting badly-formed variable locations into "no location" rather than crashing the compiler SGTM. Is it worth fixing the defect in the bug report too in a separate patch?

Separate patch is best IMO, it'll manifest as a dropped location right now, which is also what fixing the function mentioned in the bug report will do. This also gives more choices when cherry picking to the release branch.

================
Comment at: llvm/test/DebugInfo/MIR/InstrRef/livedebugvalues_illegal_locs.mir:3-4
+  ; RUN: llc %s -march=x86-64 -run-pass=livedebugvalues -o - -experimental-debug-variable-locations |  FileCheck %s -implicit-check-not=DBG_VALUE
+  ;
+  ;
+
----------------
Orlando wrote:
> Could you add a sentence to describe the purpose of the test?
Good point, I'll fold that into the landed verion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118998/new/

https://reviews.llvm.org/D118998