[PATCH] D118998: [DebugInfo][InstrRef] Don't fire assertions if broken debug-info is seen

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 04:19:44 PST 2022


Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM. Converting badly-formed variable locations into "no location" rather than crashing the compiler SGTM. Is it worth fixing the defect in the bug report too in a separate patch?



================
Comment at: llvm/test/DebugInfo/MIR/InstrRef/livedebugvalues_illegal_locs.mir:3-4
+  ; RUN: llc %s -march=x86-64 -run-pass=livedebugvalues -o - -experimental-debug-variable-locations |  FileCheck %s -implicit-check-not=DBG_VALUE
+  ;
+  ;
+
----------------
Could you add a sentence to describe the purpose of the test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118998/new/

https://reviews.llvm.org/D118998



More information about the llvm-commits mailing list