[PATCH] D119394: [lld-macho][nfc] Centralize usages of ld64.lld in tests

Vincent Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 17:50:46 PST 2022


thevinster added a comment.

> Unfortunately, we can't start with %lld anymore otherwise it would get replaced with the value of %lld and then just append -noarg which makes the command invalid. I'm happy to change it to %no-arg-lld.

I stand corrected. If we move that substitution before we define `%lld` then it should work. So, in theory `%lld-no-arg` and `%lld-noarg` should work. Although, I do like `%no-arg-lld` a bit better since it matches with how no_fatal_warnings is defined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119394/new/

https://reviews.llvm.org/D119394



More information about the llvm-commits mailing list