[PATCH] D119394: [lld-macho][nfc] Centralize usages of ld64.lld in tests

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 17:50:38 PST 2022


oontvoo added a comment.

In D119394#3309676 <https://reviews.llvm.org/D119394#3309676>, @int3 wrote:

> Yeah I think this will make testing a bit more convenient. @thakis @oontvoo, any objections?

LGTM

> Bikeshedding: How about `%lld-noarg`? It's a bit more descriptive and only two characters longer.

(slightly) prefer lld-noarg as well. :) 
On the other hand, why doesn't re-using `%lld` plus additional args, which would override the defalut ones provided by `%lld` anyways, work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119394/new/

https://reviews.llvm.org/D119394



More information about the llvm-commits mailing list