[PATCH] D119310: Add support to dsymutil for dumping out new swift5 reflection sections

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham marked 2 inline comments as done.
rastogishubham added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Swift.def:29
+                     ".sw5prtc$B")
+HANDLE_SWIFT_SECTION(protocs, "__swift5_protos", "swift5_protocols",
+                     ".sw5prt$B")
----------------
aprantl wrote:
> Is the `protocs` name one you came up with or does the Swift compiler use that too? It seems `protos` without the `c` would be closer to the actual section name, but if the Swift compiler uses `protocs`, we should use that here, too.
This is the name that was in /Users/shubham/Development/apple/swift/include/swift/ABI/ObjectFile.h I did not come up with any names myself. Just used the names that Artem came up with


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119310/new/

https://reviews.llvm.org/D119310