[PATCH] D119310: Add support to dsymutil for dumping out new swift5 reflection sections

Wed Feb 9 12:54:35 PST 2022

aprantl accepted this revision.
aprantl added a comment.

LGTM with one question inline.

================
Comment at: llvm/include/llvm/BinaryFormat/Swift.def:29
+                     ".sw5prtc$B")
+HANDLE_SWIFT_SECTION(protocs, "__swift5_protos", "swift5_protocols",
+                     ".sw5prt$B")
----------------
Is the `protocs` name one you came up with or does the Swift compiler use that too? It seems `protos` without the `c` would be closer to the actual section name, but if the Swift compiler uses `protocs`, we should use that here, too.

================
Comment at: llvm/test/tools/dsymutil/X86/reflection-dump.test:47
+CHECK: Contents of section __DWARF,__swift5_proto:
+CHECK-NEXT: 10000e258 41424344 45464748 4950               ABCDEFGHIP
+
----------------
Test looks good!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119310/new/

https://reviews.llvm.org/D119310