[PATCH] D119196: [RISCV][VP] Lower VP_FMA to RVV instructions.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 08:23:08 PST 2022


craig.topper added a comment.

In D119196#3307359 <https://reviews.llvm.org/D119196#3307359>, @frasercrmck wrote:

> Now that D118810 <https://reviews.llvm.org/D118810> landed, I think we can rebase this and switch `true_mask` patterns to use `V0` and rely on the post-process step to select the unmasked FMAs. You'll need to add the mask information to the ternary pseudos, by subclassing them from 
> `RISCVMaskedPseudo`.  Hopefully that should cut down on the net pattern gain.

The existing operand copying rules in the post-process don't work for FMAs. We need to retain the merge operand during the conversion and I'm not sure how to detect that yet.. Can I do it as a follow up?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119196/new/

https://reviews.llvm.org/D119196



More information about the llvm-commits mailing list