[PATCH] D99033: GlobalISel: Constant fold G_PTR_ADD

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CSEMIRBuilder.cpp:203
+
+    if (Opc == TargetOpcode::G_PTR_ADD &&
+        getDataLayout().isNonIntegralAddressSpace(SrcTy.getAddressSpace()))
----------------
paquette wrote:
> probably worth a comment explaining that this needs more thought?
It's not really a property of right here, it's just nobody has seriously tried to implement these at all


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99033/new/

https://reviews.llvm.org/D99033