[PATCH] D99033: GlobalISel: Constant fold G_PTR_ADD

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

Filtering out non-integral spaces for now makes sense to me.



================
Comment at: llvm/lib/CodeGen/GlobalISel/CSEMIRBuilder.cpp:203
+
+    if (Opc == TargetOpcode::G_PTR_ADD &&
+        getDataLayout().isNonIntegralAddressSpace(SrcTy.getAddressSpace()))
----------------
probably worth a comment explaining that this needs more thought?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99033/new/

https://reviews.llvm.org/D99033