[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXIntrinsics.td:937
+class FMA_TUPLE<string V, Intrinsic I, NVPTXRegClass RC,
+                list<Predicate> Preds = [hasPTX70, hasSM80]> {
+  string Variant = V;
----------------
 I think the default should be the most useful/common and the least surprising value.
I'd argue that in this case it would be `[]`.  This would give reader a reasonable idea about what's going on even without looking at FMA_TUPLE implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118977/new/

https://reviews.llvm.org/D118977