[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

Tue Feb 8 08:40:22 PST 2022

jchlanda added a comment.

In D118977#3302158 <https://reviews.llvm.org/D118977#3302158>, @tra wrote:

> In D118977#3299974 <https://reviews.llvm.org/D118977#3299974>, @jchlanda wrote:
>
>>> Target ISA Notes
>>> Requires sm_53 or higher.
>
> I think we do need this constraint applied to the new builtins, too. Right now nothing stops using them on a GPU where they do not exist and that will likely crash the compiler when we fail to find a matching intrinsic.

You are right, it would lead to unexpected crashes, I wrongly assumed that since the lowest version guarded against is PTX 6.0/SM_60, anything lower than that should be OK. Fixed now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118977/new/

https://reviews.llvm.org/D118977