[PATCH] D119229: [NVPTX] Remove image/sampler special case in call lowering

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

In D119229#3305586 <https://reviews.llvm.org/D119229#3305586>, @nikic wrote:

> In D119229#3305530 <https://reviews.llvm.org/D119229#3305530>, @tra wrote:
>
>> I have absolutely no idea what OpenCL does with sample/texture handles. You may want to find whoever added the code.
>
> This code exists since the NVPTX backend was first merged, and it looks like the person who added it hasn't been active in many years.
>
> Poking around a bit, I suspect that this is now handled in a different way by this code: https://github.com/llvm/llvm-project/blob/f231599666c7bf93086fe9b1d6687d62355d2871/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp#L1400-L1431

That code also came with the initial drop of NVPTX back-end: https://github.com/llvm/llvm-project/blame/f231599666c7bf93086fe9b1d6687d62355d2871/llvm/lib/Target/NVPTX/NVPTXUtilities.cpp#L158

Considering that handles do need special handling, it looks to me that OpenCL targeting NVPTX may be currently broken. 
That leaves potential external IR users that may depend on this argument lowering. Googling for `struct._image2d_t` suggests that there are none as there are only a few references, most of them pointing back at LLVM.

Let's land it and see what happens.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119229/new/

https://reviews.llvm.org/D119229