[PATCH] D119229: [NVPTX] Remove image/sampler special case in call lowering

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 11:49:02 PST 2022


nikic added a comment.

In D119229#3305530 <https://reviews.llvm.org/D119229#3305530>, @tra wrote:

> I have absolutely no idea what OpenCL does with sample/texture handles. You may want to find whoever added the code.

This code exists since the NVPTX backend was first merged, and it looks like the person who added it hasn't been active in many years.

Poking around a bit, I suspect that this is now handled in a different way by this code: https://github.com/llvm/llvm-project/blob/f231599666c7bf93086fe9b1d6687d62355d2871/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp#L1400-L1431


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119229/new/

https://reviews.llvm.org/D119229



More information about the llvm-commits mailing list