[PATCH] D118216: [RISCV] eliminate rematerialization of array's base address

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

This seems conceptually wrong to me. isAsCheapAsAMove is meant to model how expensive an instruction is to execute, but how you compute the immediate it uses has zero bearing on that. `lui rd, 0x123` and `lui rd, %hi(sym)` if `%hi(sym)` happens to be 0x123 are completely indistinguishable from the perspective of the processor. To me this screams of something elsewhere getting cost modelling wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118216/new/

https://reviews.llvm.org/D118216