[PATCH] D118216: [RISCV] eliminate rematerialization of array's base address

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

The only issue I have is that the description is specifically talking about arrays' base addresses but the change has wider-reaching consequences than just LICM: CSE, register allocation, sinking, etc. It's not even a loop-unroll specific change, right? This would apply to non-unrolled loops too, presumably.

So for me it'd be best for:
a) the commit title to reflect the code change itself
b) the description to describe why "MO_HI" is not as cheap as a move //in principle//
c) use array base address rematerialization as one motivating example.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118216/new/

https://reviews.llvm.org/D118216