[PATCH] D99032: GlobalISel: Add FoldBinOpIntoSelect combine

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3148
+
+  LLT Ty = MRI.getType(Dst);
+  unsigned BinOpcode = MI.getOpcode();
----------------
foad wrote:
> Since you claim to handle shift opcodes, you should cope with them having different LHS and RHS types.
It does cope with it, we don't actually care about the source operand types at this point. This is already covered in the tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99032/new/

https://reviews.llvm.org/D99032