[PATCH] D99032: GlobalISel: Add FoldBinOpIntoSelect combine

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3099
+      if (Select->getOpcode() != TargetOpcode::G_SELECT || !MRI.hasOneNonDBGUse(RHS))
+      return false;
+  }
----------------
Weird indentation?


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3148
+
+  LLT Ty = MRI.getType(Dst);
+  unsigned BinOpcode = MI.getOpcode();
----------------
Since you claim to handle shift opcodes, you should cope with them having different LHS and RHS types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99032/new/

https://reviews.llvm.org/D99032