[PATCH] D119150: [SDAG] move x86 select-with-identity-constant fold behind a target hook; NFC

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2124
+  const TargetLowering &TLI = DAG.getTargetLoweringInfo();
+  if (!TLI.shouldFoldBinopIntoSelect(Opcode, VT))
+    return SDValue();
----------------
pengfei wrote:
> Nit: should this be moved out of the function and named `shouldFoldSelectWithIdentityConstant`?
Yes - that is better. Will update. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119150/new/

https://reviews.llvm.org/D119150