[PATCH] D119150: [SDAG] move x86 select-with-identity-constant fold behind a target hook; NFC
Phoebe Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 8 05:46:18 PST 2022
pengfei added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2124
+ const TargetLowering &TLI = DAG.getTargetLoweringInfo();
+ if (!TLI.shouldFoldBinopIntoSelect(Opcode, VT))
+ return SDValue();
----------------
Nit: should this be moved out of the function and named `shouldFoldSelectWithIdentityConstant`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119150/new/
https://reviews.llvm.org/D119150
More information about the llvm-commits
mailing list