[PATCH] D119150: [SDAG] move x86 select-with-identity-constant fold behind a target hook; NFC

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 05:24:22 PST 2022


spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:33421
 
+bool X86TargetLowering::shouldFoldBinopIntoSelect(unsigned Opcode, EVT VT) const {
+  // TODO: This is too general. There are cases where pre-AVX512 codegen would
----------------
LuoYuanke wrote:
> Does this line exceed 80?
Yes, I missed formatting this chunk. Will fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119150/new/

https://reviews.llvm.org/D119150



More information about the llvm-commits mailing list