[PATCH] D119150: [SDAG] move x86 select-with-identity-constant fold behind a target hook; NFC

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 05:18:23 PST 2022


LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:33421
 
+bool X86TargetLowering::shouldFoldBinopIntoSelect(unsigned Opcode, EVT VT) const {
+  // TODO: This is too general. There are cases where pre-AVX512 codegen would
----------------
Does this line exceed 80?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119150/new/

https://reviews.llvm.org/D119150



More information about the llvm-commits mailing list