[PATCH] D119006: [AMDGPU] SILoadStoreOptimizer: avoid unbounded register pressure increases

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 23:48:16 PST 2022


piotr added a comment.

In D119006#3302156 <https://reviews.llvm.org/D119006#3302156>, @foad wrote:

> In D119006#3301526 <https://reviews.llvm.org/D119006#3301526>, @piotr wrote:
>
>> So that indicates an improvement in the average vgpr count.
>
> Yes.
>
>> Btw, does the patch result in a noticeably smaller number of merges on average?
>
> No, to my surprise there was absolutely no difference in the amount of merging in any of the 10,000 shaders. I checked by diffing the instruction mix for each shader. The only differences were in VALU and SALU instructions.

Cool, that's even better - it means the improved vgpr count was not achieved at the expense of the actual merging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119006/new/

https://reviews.llvm.org/D119006



More information about the llvm-commits mailing list