[PATCH] D118545: [ARM] Fix 8-bit immediate overflow in the instruction of segmented stack prologue.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

When the integrated assembler is used directly by the compiler, as opposed to parsing textual assembler, it uses a different codepath which passes the operands directly, which skips converting them to/from text.  This codepath ends up skipping some kinds of operand validation; we don't expect to be generating invalid instructions.

We do have a method ARMBaseInstrInfo::verifyInstruction which is used by the machine verifier to validate target-specific properties of instructions.  It currently only verifies immediates for load/store instructions, not arithmetic, so it doesn't currently catch this.  Improvements are definitely welcome, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118545/new/

https://reviews.llvm.org/D118545