[PATCH] D112724: Officially deprecate LLVM_ENABLE_PROJECTS for libc++, libc++abi and libunwind

[Louis Dionne via Phabricator via llvm-commits]

ldionne added inline comments.


================
Comment at: llvm/CMakeLists.txt:87
 if( LLVM_ENABLE_PROJECTS STREQUAL "all" )
   set( LLVM_ENABLE_PROJECTS ${LLVM_ALL_PROJECTS})
 endif()
----------------
thakis wrote:
> ...this is below the warning you added. So if you say LLVM_ALL_PROJECTS=all you still get the old behavior, without a warning. Is that intentional?
> 
> (Doesn't affect us, just happened to notice it while reading this file.)
I think it was intentional -- I didn't intend to issue a warning for folks who use `all` if they are not using `libcxx`, `libcxxabi` or `libunwind` explicitly. I think the next step would be to remove `libcxx`, libcxxabi` and `libunwind` from `all`, and to make this warning into an error since we don't support this anymore as of the branch point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112724/new/

https://reviews.llvm.org/D112724