[PATCH] D112724: Officially deprecate LLVM_ENABLE_PROJECTS for libc++, libc++abi and libunwind

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/CMakeLists.txt:67
 # one for llvm+clang+... using the same sources.
 set(LLVM_ALL_PROJECTS "clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;libcxx;libcxxabi;libunwind;lld;lldb;mlir;openmp;polly;pstl")
 # The flang project is not yet part of "all" projects (see C++ requirements)
----------------
libcxx libcxxabi libunwind are still part of LLVM_ALL_PROJECTS and...


================
Comment at: llvm/CMakeLists.txt:87
 if( LLVM_ENABLE_PROJECTS STREQUAL "all" )
   set( LLVM_ENABLE_PROJECTS ${LLVM_ALL_PROJECTS})
 endif()
----------------
...this is below the warning you added. So if you say LLVM_ALL_PROJECTS=all you still get the old behavior, without a warning. Is that intentional?

(Doesn't affect us, just happened to notice it while reading this file.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112724/new/

https://reviews.llvm.org/D112724